Person before flipped a bunch of if checks to put the value before the variable (if 6==x rather then if x==6). They messed up a bunch of the <= and >= checks by forgetting to reverse them. I improved performance and fixed numerous bugs by tracking those down.
Comments
Person before flipped a bunch of if checks to put the value before the variable (if 6==x rather then if x==6). They messed up a bunch of the <= and >= checks by forgetting to reverse them. I improved performance and fixed numerous bugs by tracking those down.
Ah yes, yoda conditionals. Because guarding against accidentally typoing
if(x=6)is worth destroying your code’s readability.This is not never anymore thanks to compiler warnings
Tell that to my colleague who still insists on writing if conditions like that. Maybe it’s just a PHP thing.
Sign in to comment. Sign in